Constify results from stdlib functions

This fixes recent warnings:

../src/st/croco/cr-rgb.c: In function ‘cr_rgb_set_from_name’:
../src/st/croco/cr-rgb.c:405:16: warning: assignment discards ‘const’
qualifier from pointer target type [-Wdiscarded-qualifiers]
  405 |         result = bsearch (a_color_name,
      |                ^
[150/294] Compiling C object src/libshell-18.so.p/shell-util.c.o
../src/shell-util.c: In function ‘shell_util_translate_time_string’:
../src/shell-util.c:165:7: warning: assignment discards ‘const’
qualifier from pointer target type [-Wdiscarded-qualifiers]
  165 |   sep = strchr (str, '\004');
      |       ^

which seem to originate from:

https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=cd748a63ab1a7ae846175c532a3daab341c62690;hp=64b6813338d836ad1b61969a153192fb739f8722

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4139>

diff --git a/src/shell-util.c b/src/shell-util.c
index da056a01522d66d0199c89895c4ebbcf8c24c52f..382fa2b45992ea3a3f4ba45933145839d8fd0717 100644 (file)
--- a/src/shell-util.c
+++ b/src/shell-util.c
@@ -153,7 +153,7 @@ shell_util_translate_time_string (const char *str)
 {
   const char *locale = g_getenv ("LC_TIME");
   const char *res;
-  char *sep;
+  const char *sep;
   locale_t old_loc;
   locale_t loc = (locale_t) 0;
 

diff --git a/src/st/croco/cr-rgb.c b/src/st/croco/cr-rgb.c
index a2b478f7c1aa0c26cb4cf83395b70403292b50c2..4691e961cce6101926b317c9c9027804a11dd7d0 100644 (file)
--- a/src/st/croco/cr-rgb.c
+++ b/src/st/croco/cr-rgb.c
@@ -398,7 +398,7 @@ enum CRStatus
 cr_rgb_set_from_name (CRRgb * a_this, const guchar * a_color_name)
 {
         enum CRStatus status = CR_OK;
-        CRRgb *result;
+        const CRRgb *result;
 
         g_return_val_if_fail (a_this && a_color_name, CR_BAD_PARAM_ERROR);